Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change URL of nsq-lookup dependency to not require authentication #11

Closed
nunojsferreira opened this issue Dec 30, 2019 · 1 comment · Fixed by #15
Closed

Change URL of nsq-lookup dependency to not require authentication #11

nunojsferreira opened this issue Dec 30, 2019 · 1 comment · Fixed by #15

Comments

@nunojsferreira
Copy link

Currently package.json defines the nsq-lookup dependency with a direct link to a commit, using the git+ssh:// protocol:

"nsq-lookup": "git+ssh://[email protected]/uphold-forks/nsq-lookup#1e6e4eb37a07649a5dc430dbf69b65c1b05253be",

That means that, even though both this repo and nsq-lookup are public, any project depending on this one will require SSH keys added to Travis CI in order to clone the repositories and run the test suite.

To fix this, the dependency on nsq-lookup should be changed to a https:// URL, so that cloning can occur without SSH keys.

@risantos
Copy link

Updated on #15.
Diff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants