Refactor project #15
Merged
Refactor project #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Americas
force-pushed
the
support/refactor-project
branch
from
f1e0745
to
3a02641
Compare
Americas
force-pushed
the
support/refactor-project
branch
10 times, most recently
from
b0a9507
to
7be5b8d
Compare
Americas
force-pushed
the
support/refactor-project
branch
from
7be5b8d
to
3d7fbf8
Compare
Americas
force-pushed
the
support/refactor-project
branch
from
3d7fbf8
to
b82241f
Compare
satazor
reviewed
Feb 19, 2024
lib/utils.js
Outdated
| return { | ||
| host: str.split(':')[0], | ||
| port: str.split(':')[1] | ||
| exports.parseAddress = str => { |
There was a problem hiding this comment.
Small inconsistency: we are using exports and in other places module.exports. Do we want to standardize it?
Americas
force-pushed
the
support/refactor-project
branch
from
b82241f
to
1e532c4
Compare
- Add linter - Refactor `Framer` class - Refactor `Connection` class - Refactor `Message` class - Refactor utils - Refactor `Reader` class - Refactor `Writer` class - Refactor mixins - Refactor examples - Refactor index.js - Update dependencies - Refactor Readme.md - Add minimum node engine version - Add test github action
Americas
force-pushed
the
support/refactor-project
branch
from
1e532c4
to
bae9178
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the code style to more modern standards.
Notable changes:
subscribedevent on theReaderclass (used on a test to avoid using setTimeout to wait for setup).shoulddev dependency.Closes #11