Handle nsqd disconnects #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Americas
force-pushed
the
support/handle-disconnections
branch
from
b0b6b3a
to
58964b4
Compare
jspranger
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Code-wise, looks fine.
I have tested in the reliability cluster with the backend project and multiple nsqlookupd instances.
I've scaled down all nsqlookupd instances and executed a transaction, which remained processing.
Once I scaled back up an instance of nsqlookupd the transaction completed.
Handlers that didn't have this commit in them, crashed once the nsqlookupd was scaled down. No disruptions were observed to the handlers that had this commit.
LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR essentially does 2 things :
errortoerror lookup, this makes it so that lookup failures don't have to be handled, and don't interfere with actual reader errors.disconnectevent if the max reconnection attempts for a connection is reached. This is used in the reader to remove these connections from the set of active connections.