Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests and prevent errors when removing the map #527

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix tests and prevent errors when removing the map #527

wants to merge 2 commits into from

Commits on Mar 13, 2023

  1. chore(deps): revert @deck.gl/layers to 8.8.9 

    This fixes the tests that were failing. It looks like @deck.gl uses
dependencies that were converted to esm modules and jest isn't currently
set up to handle them.

```
Jest encountered an unexpected token
...
/home/runner/work/react-map-gl/react-map-gl/node_modules/@deck.gl/layers/node_modules/@mapbox/tiny-sdf/index.js:3
export default class TinySDF {
^^^^^^

SyntaxError: Unexpected token 'export'
```

Reference: visgl/deck.gl#7735
    @josh-cloudscape
    josh-cloudscape committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    c764e1f View commit details
    Browse the repository at this point in the history

  2. fix(image): don't add images if map or component is unloaded 

    Prevents errors when unmounting the map while images are still loading.
    @josh-cloudscape
    josh-cloudscape committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    36cb600 View commit details
    Browse the repository at this point in the history