Skip to content

Commit

Permalink
[MINOR] Fix a typo in First aggregate expression
Browse files Browse the repository at this point in the history
### What changes were proposed in this pull request?
Find a typo for the comment on code `mergeExpressions` of `First` aggregate expression,  fix from `first.right` to `first.left`.

### Why are the changes needed?
Fix typo, it's confused.

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
N.A

### Was this patch authored or co-authored using generative AI tooling?
No

Closes apache#48298 from exmy/fix-comment.

Authored-by: exmy <[email protected]>
Signed-off-by: Max Gekk <[email protected]>
  • Loading branch information
exmy authored and MaxGekk committed Oct 1, 2024
1 parent 97e9bb3 commit 3093ad6
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ case class First(child: Expression, ignoreNulls: Boolean)

override lazy val mergeExpressions: Seq[Expression] = {
// For first, we can just check if valueSet.left is set to true. If it is set
// to true, we use first.right. If not, we use first.right (even if valueSet.right is
// to true, we use first.left. If not, we use first.right (even if valueSet.right is
// false, we are safe to do so because first.right will be null in this case).
Seq(
/* first = */ If(valueSet.left, first.left, first.right),
Expand Down

0 comments on commit 3093ad6

Please sign in to comment.