moved the data constant outside of the ssrExchange closure #3652
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In scenarios when ssrExchange was called multiple times, each time a new reference of the
data
constant was created. However, within thessr
function defined insidessrExchange
, only the very first reference of the data variable was used, which caused a mismatch. For example, in Next.js this caused a bug where during client-side navigation, if a query was prefetched insidegetServerSideProps
of the page the user has navigated to, the result was stored in the SSR cache, but it was never used, as it was filled into a different object (different reference) than the one that was used originally. Because of this, the URQL client searched for the data in the wrong place and it never found it. This caused the query to be refetched and the layout to shift because of the missing data.Set of changes
The data constant (object to which the SSR-prefetched data is stored) was moved outside of the
ssrExchange
closure to ensure just a single reference being used.