USAGOV-1870 - Published Page Report to handle taxonomy terms

[DaleMHFrey]

USAGOV-1870 - Published Page Report to handle taxonomy terms

https://cm-jira.usa.gov/browse/USAGOV-1870

Description

• Updated the code to catch a logic bug where taxonomyID was being ignored, and thus sometimes adding in an extra column at the end (for taxonomy terms)
• Updated the logic to understand the difference between node-IDs and taxonomy-IDs when looking up the "pointer"

Type of Changes

• New Feature
• Bugfix
• Frontend (Twig, Sass, JS)
  • Add screenshot showing what it should look like
• Drupal Config (requires "drush cim")
• New Modules (requires rebuild)
• Documentation
• Infrastructure
  • CMS
  • WAF
  • Egress
  • Tools
• Other

Testing Instructions

Run Tome, and expect "t_" to exist under the "Page ID" column for taxonomy-terms.

Change Requirements

• Requires New Documentation (Link: {})
• Requires New Config
• Requires New Content

Validation Steps

• Test instruction 1
• Test instruction 2
• Test instruction 3

Security Review

• Adds/updates software (including a library or Drupal module)
• Communication with external service
• Changes permissions or workflow
• Requires SSPP updates

Reviewer Reminders

• Reviewed code changes
• Reviewed functionality
• Security review complete or not required

Post PR Approval Instructions

Follow these steps as soon as you merge the new changes.

1. Go to the USAGov Circle CI project.
2. Find the commit of this pull request.
3. Build and deploy the changes.
4. Update the Jira ticket by changing the ticket status to Review in Test and add a comment. State whether the change is already visible on cms-dev.usa.gov and beta-dev.usa.gov, or if the deployment is still in process.

[akf]

I caught a subtle bug here -- see below.

Btw, it might not have been clear -- we're referring back to the contents of the file not because we think the same page might be rendered twice, but because Tome doesn't always render all the pages. It's great that Tome can just update the pages that need an update, but we need the report to contain an entry for every page. So we build on the existing CSV file.

[akf]

@DaleMHFrey just a heads up, there's a silly lint error on this PR and that's why I haven't reviewed it again; could you clear that up please?

[DaleMHFrey]

@DaleMHFrey just a heads up, there's a silly lint error on this PR and that's why I haven't reviewed it again; could you clear that up please?
Oops - this fell off my radar. This is now fixed.