Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USAGOV-1981-timestamp-format: Replace cf event api timestamp w/ ISO8601-like timestamp #1976

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

arpage
Copy link
Collaborator

@arpage arpage commented Sep 24, 2024

Jira Task

https://cm-jira.usa.gov/browse/USAGOV-1981

Description

  1. Pull old timestamp out of event string
  2. Modify timestamp to be ISO8601-like
  3. Re-insert timestamp into event

Type of Changes

  • New Feature
  • Bugfix
  • Frontend (Twig, Sass, JS)
    • Add screenshot showing what it should look like
  • Drupal Config (requires "drush cim")
  • New Modules (requires rebuild)
  • Documentation
  • Infrastructure
    • CMS
    • WAF
    • WWW
    • Egress
    • Tools
    • Cron
  • Other

Testing Instructions

New events should be visible in NR, with a correct UTC timestamp (use the Live-tail function, with a query of "cfevent.entity.space_name:dr" [replace "dr" with the space you are testing in])

Change Requirements

  • Requires New Documentation (Link: {})
  • Requires New Config
  • Requires New Content

Validation Steps

  • Test instruction 1
  • Test instruction 2
  • Test instruction 3

Security Review

  • Adds/updates software (including a library or Drupal module)
  • Communication with external service
  • Changes permissions or workflow
  • Requires SSPP updates

Reviewer Reminders

  • Reviewed code changes
  • Reviewed functionality
  • Security review complete or not required

Post PR Approval Instructions

Follow these steps as soon as you merge the new changes.

  1. Go to the USAGov Circle CI project.
  2. Find the commit of this pull request.
  3. Build and deploy the changes.
  4. Update the Jira ticket by changing the ticket status to Review in Test and add a comment. State whether the change is already visible on cms-dev.usa.gov and beta-dev.usa.gov, or if the deployment is still in process.

@arpage arpage added the WIP Do not merge label Sep 25, 2024
@arpage arpage marked this pull request as draft September 25, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Do not merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant