Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USAGOV-2001 samlauth default config and stage config #1999

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

arpage
Copy link
Collaborator

@arpage arpage commented Oct 8, 2024

Jira Task

https://cm-jira.usa.gov/browse/USAGOV-2001

Description

Add logic to samlauth config chooser script which will enable the SecureAuth configuration if there is no environment-specific config file.

Also, add GSAAuth config file for the stage environment.

Type of Changes

  • New Feature
  • Bugfix
  • Frontend (Twig, Sass, JS)
    • Add screenshot showing what it should look like
  • Drupal Config (requires "drush cim")
  • New Modules (requires rebuild)
  • Documentation
  • Infrastructure
    • CMS
    • WAF
    • WWW
    • Egress
    • Tools
    • Cron
  • Other

Testing Instructions

It would be difficult to test this PR as-is, because the 2 situations where it is currently applicable is:

  1. In stage, where the effect of this PR is to enable GSAAuth SSO.
  2. In prod, where the effect of this PR is to enable SecureAuth SSO.

Please note however, that the first commit successfully tested the "default" scenario (by renaming the DR config file).
The stage scenario has not been tested yet, as it would not work outside of the stage environment.

Change Requirements

  • Requires New Documentation (Link: {})
  • Requires New Config
  • Requires New Content

Validation Steps

  1. When deployed to stage, GSAAuth SSO should function as expected.
  2. When deployed to prod, SecureAuth SSO should function as expected (unless this PR superceded by another, which provides the GSAAuth config for the prod environment).

Security Review

  • Adds/updates software (including a library or Drupal module)
  • Communication with external service
  • Changes permissions or workflow
  • Requires SSPP updates

Reviewer Reminders

  • Reviewed code changes
  • Reviewed functionality
  • Security review complete or not required

Post PR Approval Instructions

Follow these steps as soon as you merge the new changes.

  1. Go to the USAGov Circle CI project.
  2. Find the commit of this pull request.
  3. Build and deploy the changes.
  4. Update the Jira ticket by changing the ticket status to Review in Test and add a comment. State whether the change is already visible on cms-dev.usa.gov and beta-dev.usa.gov, or if the deployment is still in process.

…o env-specific conf is found (makes this production-safe, if timeline is extended)
…ult/no matching config" scenario by renaming the DR config file. Here we will give it back it's real name so we can test the normal behavior.
@arpage arpage changed the title Usagov 2001 samlauth default config USAGOV-2001 samlauth default config and stage config Oct 8, 2024
Copy link
Member

@akf akf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable.

@akf akf merged commit ed14fcf into dev Oct 8, 2024
9 of 11 checks passed
@akf akf deleted the USAGOV-2001-samlauth-default-config branch October 8, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants