Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usagov 1951 report issue accessibility for recaptcha #2003

Open
wants to merge 10 commits into
base: dev
Choose a base branch
from

Conversation

developer43
Copy link
Contributor

Jira Task

https://cm-jira.usa.gov/browse/USAGOV-1951

Description

To make recaptcha accessible

Type of Changes

  • New Feature
  • Bugfix
  • Frontend (Twig, Sass, JS)
    • Add screenshot showing what it should look like
  • Drupal Config (requires "drush cim")
  • New Modules (requires rebuild)
  • Documentation
  • Infrastructure
    • CMS
    • WAF
    • WWW
    • Egress
    • Tools
    • Cron
  • Other

Testing Instructions

Goto http://localhost/site-issue-report-form in English and http://localhost/es/reporte-problemas-en-este-sitio-web in Spanish

Change Requirements

  • Requires New Documentation (Link: {})
  • Requires New Config
  • Requires New Content

Validation Steps

Goto http://localhost/site-issue-report-form in English and http://localhost/es/reporte-problemas-en-este-sitio-web in Spanish. The recaptcha image should be hidden.

  • Tab through the form and make sure the tabbing order goes to
    1. First Name
    1. Email Address
    1. Describe the issue box
    1. Submit button
    1. Privacy Policy link
    1. Terms of Service link
Screenshot 2024-10-10 at 9 42 02 AM Screenshot 2024-10-10 at 9 42 15 AM Screenshot 2024-10-10 at 9 42 27 AM

Security Review

  • Adds/updates software (including a library or Drupal module)
  • Communication with external service
  • Changes permissions or workflow
  • Requires SSPP updates

Reviewer Reminders

  • Reviewed code changes
  • Reviewed functionality
  • Security review complete or not required

Post PR Approval Instructions

Follow these steps as soon as you merge the new changes.

  1. Go to the USAGov Circle CI project.
  2. Find the commit of this pull request.
  3. Build and deploy the changes.
  4. Update the Jira ticket by changing the ticket status to Review in Test and add a comment. State whether the change is already visible on cms-dev.usa.gov and beta-dev.usa.gov, or if the deployment is still in process.

@YaritzaGarcia YaritzaGarcia self-requested a review October 11, 2024 19:48
@YaritzaGarcia
Copy link
Contributor

@developer43 Hello! I'm reviewing this and I noticed that after the "Terms of Service" the tab marks this

Screenshot 2024-10-11 at 4 03 01 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants