This repository has been archived by the owner on Aug 15, 2024. It is now read-only.
Feature/vote 1783 dependabot update #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md) - [Commits](npm/node-semver@v5.7.1...v5.7.2) --- updated-dependencies: - dependency-name: semver dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
….7.2' into feature/vote-1783-dependabot-update
rayestrada
suggested changes
Jul 26, 2023
There was a problem hiding this comment.
Based on Deprecation warnings I would suggest we replace our current stylelintrc file with the one that USWDS uses.
Deprecation warnings:
- The "at-rule-name-case" rule is deprecated.
- The "at-rule-name-space-after" rule is deprecated.
- The "at-rule-semicolon-newline-after" rule is deprecated.
- The "block-closing-brace-empty-line-before" rule is deprecated.
- The "block-closing-brace-newline-after" rule is deprecated.
- The "block-closing-brace-newline-before" rule is deprecated.
- The "block-closing-brace-space-before" rule is deprecated.
- The "block-opening-brace-newline-after" rule is deprecated.
- The "block-opening-brace-space-after" rule is deprecated.
- The "block-opening-brace-space-before" rule is deprecated.
- The "color-hex-case" rule is deprecated.
- The "declaration-bang-space-after" rule is deprecated.
- The "declaration-bang-space-before" rule is deprecated.
- The "declaration-block-semicolon-newline-after" rule is deprecated.
- The "declaration-block-semicolon-space-after" rule is deprecated.
- The "declaration-block-semicolon-space-before" rule is deprecated.
- The "declaration-block-trailing-semicolon" rule is deprecated.
- The "declaration-colon-newline-after" rule is deprecated.
- The "declaration-colon-space-after" rule is deprecated.
- The "declaration-colon-space-before" rule is deprecated.
- The "function-comma-newline-after" rule is deprecated.
- The "function-comma-space-after" rule is deprecated.
- The "function-comma-space-before" rule is deprecated.
- The "function-max-empty-lines" rule is deprecated.
- The "function-parentheses-newline-inside" rule is deprecated.
- The "function-parentheses-space-inside" rule is deprecated.
- The "function-whitespace-after" rule is deprecated.
- The "max-empty-lines" rule is deprecated.
- The "media-feature-colon-space-after" rule is deprecated.
- The "media-feature-colon-space-before" rule is deprecated.
- The "media-feature-name-case" rule is deprecated.
- The "media-feature-parentheses-space-inside" rule is deprecated.
- The "media-feature-range-operator-space-after" rule is deprecated.
- The "media-feature-range-operator-space-before" rule is deprecated.
- The "media-query-list-comma-newline-after" rule is deprecated.
- The "media-query-list-comma-space-after" rule is deprecated.
- The "media-query-list-comma-space-before" rule is deprecated.
- The "no-eol-whitespace" rule is deprecated.
- The "no-extra-semicolons" rule is deprecated.
- The "no-missing-end-of-source-newline" rule is deprecated.
- The "number-leading-zero" rule is deprecated.
- The "number-no-trailing-zeros" rule is deprecated.
- The "property-case" rule is deprecated.
- The "selector-attribute-brackets-space-inside" rule is deprecated.
- The "selector-attribute-operator-space-after" rule is deprecated.
- The "selector-attribute-operator-space-before" rule is deprecated.
- The "selector-combinator-space-after" rule is deprecated.
- The "selector-combinator-space-before" rule is deprecated.
- The "selector-descendant-combinator-no-non-space" rule is deprecated.
- The "selector-list-comma-newline-after" rule is deprecated.
- The "selector-list-comma-space-before" rule is deprecated.
- The "selector-max-empty-lines" rule is deprecated.
- The "selector-pseudo-class-case" rule is deprecated.
- The "selector-pseudo-class-parentheses-space-inside" rule is deprecated.
- The "selector-pseudo-element-case" rule is deprecated.
- The "unit-case" rule is deprecated.
- The "value-list-comma-newline-after" rule is deprecated.
- The "value-list-comma-space-after" rule is deprecated.
- The "value-list-comma-space-before" rule is deprecated.
- The "value-list-max-empty-lines" rule is deprecated.
- The "indentation" rule is deprecated.
rayestrada
approved these changes
Jul 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ticket -> Vote1783
This PR will update from dependabot updates
will close: #884, #878 and #876
Note - gulp stylelint and stylelint scss were removed due to not being maintained, the gulp.js file was updated from uswds example to help cover the new listing function
to test:
npm run testand check that linting is catching files that need to be updatednpm run startand ensure app is starting with no issues