Enhance remap user tasks from os_setup role #18
Conversation
Complete overhaul of `remap_user.yml`. Instead of checking only for the existence of the `galaxy` user and group, it will now go over all users and groups defined in `handy_users` and `handy_groups` and remap any existing users or groups with conflicting UIDs or GIDs.
|
What was the issue again with the OS major version separated |
I wrote this in #16
but I think I need to explain it further. Let's move the discussion to that PR as this PR is unrelated to this change. |
|
To any reviewer: reading this will help you make sense of this PR. |
kysrpex
requested review from
bgruening
and removed request for
sanjaysrikakulam
|
Can anybody have a look at this? Remember that since #16, we have the mq host filling up the disk with logs sometimes (although rarely). |
|
Would tomorrow be good enough? |
Sure! |
…to a more detailed example Extend the comments in remap_user.yml with a brief example describing the purpose of the tasks in "remap_user.yml" and a pointer to the much more detailed example located in roles/os_setup/files/remap_user.py.
The only changes since the last release are those introduced by usegalaxy-eu#18. According to https://semver.org/spec/v2.0.0.html: - "6. Patch version Z (x.y.Z | x > 0) MUST be incremented if only backward compatible bug fixes are introduced. A bug fix is defined as an internal change that fixes incorrect behavior." - "7. Minor version Y (x.Y.z | x > 0) MUST be incremented if new, backward compatible functionality is introduced to the public API. [...] It MAY be incremented if substantial new functionality or improvements are introduced within the private code." - "8. Major version X (X.y.z | X > 0) MUST be incremented if any backward incompatible changes are introduced to the public API." PR usegalaxy-eu#18 qualifies both as "substantial new functionality or improvements are introduced within the private code" and "backward compatible bug fixes", thus I am increasing the minor version number.
Complete overhaul of
remap_user.yml. Instead of checking only for the existence of thegalaxyuser and group, it will now go over all users and groups defined inhandy_usersandhandy_groupsand remap any existing users or groups with conflicting UIDs or GIDs.This should solve the nasty issues caused by #16 (sorry 😅). I trashed a disposable VM to test this.