Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Bash for all shell tasks #21

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Conversation

kysrpex
Copy link
Contributor

@kysrpex kysrpex commented Dec 20, 2023

Set executable: /bin/bash for all ansible.builtin.shell tasks for predictability.

Only affects tasks in remap_user.yml, since this is the only file containing ansible.builtin.shell tasks.

Solves this problem (relatd to usegalaxy-eu/infrastructure-playbook#1057).

TASK [usegalaxy_eu.handy.os_setup : Compute user mapping using script.] ********************************************************************************************************************
fatal: [maintenance.galaxyproject.eu -> localhost]: FAILED! => {"changed": false, "cmd": "set -o pipefail;\n./remap_user.py \\\n     -e 0:root -e 1:bin -e 2:daemon -e 3:adm -e 4:lp -e 5:sync -e 6:shutdown -e 7:halt -e 8:mail -e 11:operator -e 12:games -e 14:ftp -e 65534:nobody -e 81:dbus -e 500:systemd-coredump -e 193:systemd-resolve -e 59:tss -e 998:polkitd -e 997:unbound -e 996:sssd -e 74:sshd -e 72:tcpdump -e 995:pesign -e 32:rpc -e 29:rpcuser -e 994:telegraf -e 993:chrony -e 1000:centos -e 999:galaxy -e 499:gluster -e 989:dnsmasq -e 498:saslauth -e 497:condor -e 107:qemu \\\n     -d 999:galaxy \\\n    | tail -n +2\n", "delta": "0:00:00.004574", "end": "2023-12-20 09:08:07.362578", "msg": "non-zero return code", "rc": 2, "start": "2023-12-20 09:08:07.358004", "stderr": "/bin/sh: 1: set: Illegal option -o pipefail", "stderr_lines": ["/bin/sh: 1: set: Illegal option -o pipefail"], "stdout": "", "stdout_lines": []}

Set `executable: /bin/bash` for all `ansible.builtin.shell` tasks for predictability.

Only affects tasks in `remap_user.yml`, since this is the only file containing `ansible.builtin.shell` tasks.
@kysrpex kysrpex added the bug Something isn't working label Dec 20, 2023
@kysrpex kysrpex self-assigned this Dec 20, 2023
@kysrpex
Copy link
Contributor Author

kysrpex commented Dec 20, 2023

@sanjaysrikakulam Since we have just discussed this, I merge without approval in GitHub.

@kysrpex kysrpex merged commit 83a31c9 into usegalaxy-eu:main Dec 20, 2023
1 check passed
@kysrpex kysrpex deleted the shell_bash branch December 20, 2023 10:08
kysrpex added a commit to kysrpex/usegalaxy-eu-ansible-collection-handy that referenced this pull request Dec 20, 2023
The only changes since the last release are a bugfix usegalaxy-eu#21. Therefore, I am increasing the patch version number.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant