Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing duplicated role: usegalaxy_eu.handy.os_setup #76

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

sebastian-luna-valero
Copy link

Hello,

Is this duplication intended?

Apologies for the noise otherwise, I just wanted to check.

Best regards,
Sebastian

@sanjaysrikakulam
Copy link
Member

One file creates the GPU VGCN image, and the other creates the non-GPU VGCN image. Not redundant or duplicated.

@sebastian-luna-valero
Copy link
Author

sebastian-luna-valero commented Sep 13, 2023

Sorry, I should have been more explicit earlier.

On both playbooks, there are two calls to the role usegalaxy_eu.handy.os_setup. This PR is removing the last one.

Is this intended?

@sanjaysrikakulam
Copy link
Member

Sorry, my bad. The second one is used explicitly to enable this task enable_ansible_root_cron from the role. I will have to look into the role and the task to see what it does and whether we can have the invoke the respective task in the 1st instance itself and remove the duplicacy.

@sebastian-luna-valero
Copy link
Author

ok, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants