Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing HEADER_MESSAGE_ROOT key, updated some English to Greek #1042

Merged
merged 2 commits into from
Oct 12, 2019
Merged

Add missing HEADER_MESSAGE_ROOT key, updated some English to Greek #1042

merged 2 commits into from
Oct 12, 2019

Conversation

nikspyratos
Copy link
Contributor

@lcharette Kindly pointed out that there was still a missing locale key, so I added that.

Also modified two other keys to be less Greek-lish.

Let me know if there's anything missing.

@codecov
Copy link

codecov bot commented Oct 9, 2019

Codecov Report

Merging #1042 into hotfix will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             hotfix    #1042   +/-   ##
=========================================
  Coverage     66.66%   66.66%           
  Complexity     1931     1931           
=========================================
  Files           162      162           
  Lines          6737     6737           
=========================================
  Hits           4491     4491           
  Misses         2246     2246

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acd8007...a634d87. Read the comment docs.

@amosfolz
Copy link
Contributor

amosfolz commented Oct 9, 2019

@nikspyratos
Copy link
Contributor Author

On my old branch where I did my own version of the translations I also couldn't find a good translation for slug. In Greek, slug is translated as "naked snail" and the language isn't always as malleable with using words for new meanings.
email is colloquially used in Greece instead of the transliteration (which basically means "electronic post").
captcha is more of a pronoun on its own and Greek maintains foreign terms like that.

@lcharette
Copy link
Member

FYI, for the French locale I used the equivalent of "token" instead of slug. Because the only translation in French would also be "naked snail" :P

@nikspyratos
Copy link
Contributor Author

FYI, for the French locale I used the equivalent of "token" instead of slug. Because the only translation in French would also be "naked snail" :P

Great idea actually. Updated using "token" for slug. "Τεκμήριο" fits well enough.

@lcharette lcharette merged commit 0d8becf into userfrosting:hotfix Oct 12, 2019
@lcharette
Copy link
Member

Merged ! Thanks!

Ref #1027

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants