Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: docker files updated #105

Merged
merged 1 commit into from
Oct 16, 2024
Merged

feat: docker files updated #105

merged 1 commit into from
Oct 16, 2024

Conversation

seeratawan01
Copy link
Member

@seeratawan01 seeratawan01 commented Oct 16, 2024

PR Type

formatting


Description

  • Corrected indentation in docker-compose.yaml for the ports mapping.
  • Added missing newlines at the end of default.conf and nginx.conf.
  • Removed unnecessary trailing spaces in nginx.conf.

Changes walkthrough 📝

Relevant files
Formatting
docker-compose.yaml
Correct indentation in docker-compose file                             

packages/javascript-sdk/docker-compose.yaml

  • Fixed indentation for the ports mapping.
+1/-1     
default.conf
Add newline at end of default.conf file                                   

packages/javascript-sdk/docker/default.conf

  • Added a newline at the end of the file.
+1/-1     
nginx.conf
Clean up nginx.conf file formatting                                           

packages/javascript-sdk/docker/nginx.conf

  • Added a newline at the end of the file.
  • Removed unnecessary trailing spaces.
  • +2/-2     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    🏅 Score: 92
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Trailing Space
    The addition of a trailing space may be unintentional and could lead to potential formatting issues in the future.

    Code feedback:
    relevant filepackages/javascript-sdk/docker/nginx.conf
    suggestion      

    Remove the trailing space added on line 21 to maintain clean and consistent formatting. [important]

    relevant line

    Copy link

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @seeratawan01 seeratawan01 merged commit 2e7771b into develop Oct 16, 2024
    1 of 2 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant