[USH-1510] Use only parameters for posts in web client #1418
Conversation
There was a problem hiding this comment.
There is one silly side-effect on this change, when trying to publish a post from the post-list, the post_content isn't there so the code cannot properly check that all required tasks are completed. It is happening here:https://github.com/ushahidi/platform-client-mzima/blob/development/apps/web-mzima-client/src/app/post/post-head/post-head.component.ts#L86. I think that in the cases when a user is publishing from the feed-view, we would actually need to get the full post. Maybe you can add a check to see if the full post is there, and if not, get it and do the check? It only applies to when the user clicks on "Publish" in the feed-view, not in detailed view.
| // Brute force extraction of the first image found in a post. | ||
| // Ugly approach, but it stops as soon as it finds an image. | ||
| // TODO: Optimise | ||
| if (this.post.post_content) { |
There was a problem hiding this comment.
Hehe, finally we got rid of "TODO: Optimise" 🤗
|
I've added the change, do this work? @Angamanga |
|
This is ready for review too @Angamanga |
No description provided.