Edit post: Unable to specifically remove "Add caption" field for image #734
+43
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Angamanga
reviewed
Jan 8, 2024
There was a problem hiding this comment.
When I test this out locally, the API complains about "The PATCH method is not supported for this route. Supported methods: GET, HEAD, PUT, DELETE." when trying to save a new caption/remove a caption. Does it work for you locally @ushahidlee?
| @@ -2,13 +2,13 @@ import { HttpClient } from '@angular/common/http'; | |||
| import { Injectable } from '@angular/core'; | |||
| import { apiHelpers } from '../helpers'; | |||
| import { EnvLoader } from '../loader'; | |||
| import { MediaResponse } from '../models'; | |||
| // import { MediaResponse } from '../models'; | |||
| import { ResourceService } from './resource.service'; | |||
There was a problem hiding this comment.
Should MediaResponse be removed?
Angamanga
reviewed
Jan 8, 2024
| updatedPost.post_content = p.post_content; | ||
| this.posts = this.posts.map((obj) => (obj.id === updatedPost.id ? updatedPost : obj)); | ||
| } | ||
| const updatedPost = _.cloneDeep(p); |
|
@Angamanga Yes this ticket can only be tested with a corresponding PR on platform |
|
@ushahidlee Aahh, got it. Good time for me to set the API up then 🤓 |
tuxpiper
pushed a commit
that referenced
this pull request
Jan 15, 2024
#734) * Uses the caption field for updates and a media patch rest * fixed bug, still needs to propagate change * Fixed reactivity issue in feed. * removed un-necessary objecty things * Slight modification to match CQRS changes in backend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes USH-777