[Outreachy Task Submission] Fixed Mobile Screen Navigation at the bottom of the screen menubar #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crocmons
changed the title
crocmons
changed the title
crocmons
changed the title
Angamanga
requested changes
Mar 23, 2024
There was a problem hiding this comment.
Thank you for your PR. While this solves the problem, there is actually something else that causes this problem, not that the button is actually there or not. I would rather keep the button since its a piece of functionality. My hint is: Check the positioning and use of CSS for the share-button :).
...-client/src/app/shared/components/fragments/share-and-donate/share-and-donate.component.html
Outdated
Show resolved
Hide resolved
…latform-client-mzima into #4807-fixed-mobile-navigation
… page (ushahidi#806) Co-authored-by: Shakira <[email protected]>
* update-test * fix failing test * the test is fine, the platform is broken
…shahidi#827) * wip wip wip * Added location handling --------- Co-authored-by: ushahidlee <[email protected]> , Angamanga <[email protected]>
* add step to reveal child category * fix failing category test
* wip wip wip * Added location handling * Fix for required fields. * removed stupid comment --------- Co-authored-by: Anna Iosif <[email protected]>
* Fix: Submitting post via mobile app (ushahidi#829) * Gives each date|time widget a unique id so they can be dealt with separately. (ushahidi#792) * fix(USH-1128): rewrite mobile image uploader component --------- Co-authored-by: ushahidlee <[email protected]> * chore: bump to mobile app version 2.202410.0 * chore: remove backend_url env.json to avoid it being built into mobile app * chore: remove feature from create/edit collection form * chore: fix issue with fetching api url when no choosen deployment --------- Co-authored-by: ushahidlee <[email protected]>
…i#892) * Bug fixes * Fixing duplication across tasks * Tidied and removed un-necessary translation code
* update cypress to latest version * remove unused configuration * rerun tests --------- Co-authored-by: Walt <[email protected]>
* add waits to stabilize edit post test * fix failing edit post test
…page size (ushahidi#802) * fix disappearing account info browser resize * add function to detect mobile devices * make requested fixes --------- Co-authored-by: Anna Iosif <[email protected]>
…ore they're published (ushahidi#861) * Add tests for survey configurations * Correct test method * Add specific locator for survey * Fix failing tests * Fix failing tests * Add force true * Rectify the locator in the form * Fix locators * Edit the locators for the selected survey item * Edit the locators * Fix failing test * Fix failing test * Ensure locator is updated * Remove the force true on save * Clear filters * Edit clear locator * Add wait period after loading * Change status locator * Fix failing tests * minor changes to wordings around the tests * minor changes to wordings around the tests --------- Co-authored-by: Shakira <[email protected]> Co-authored-by: AmTryingMyBest <[email protected]> Co-authored-by: Walter <[email protected]>
…ma into #4807-fixed-mobile-navigation
…latform-client-mzima into #4807-fixed-mobile-navigation
|
@Angamanga the pr is now ready for review.. I have fixed all the issues and also changed the description. Please review it. |
Angamanga
approved these changes
Mar 27, 2024
|
@Angamanga To release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves issue #4807 where the menu bar at the bottom of the screen was non-functional in mobile mode, hindering users from navigating to other pages effectively. The current behavior triggered a popup share action instead of allowing navigation. To improve the user experience and accessibility on mobile devices, this PR enhances the functionality of the bottom menu bar by adding the CSS bottom position of 125px and enabling seamless navigation between pages.
Changes Made:
Screenshots/Attachments:
screencast-127.0.0.1_4200-2024.03.24-22_17_32.webm
Testing:
Impact:
With this enhancement, users can now navigate between pages seamlessly on mobile devices, improving the accessibility and usability of the application. By adding the CSS bottom position of 125px and enabling direct navigation from the bottom menu bar, I'm enhancing the overall user experience and satisfaction.
Additional Notes:
screencast-127.0.0.1_4200-2024.03.24-22_17_32.webm