Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Outreachy Task Submission] Keyboard Support For Posts Bulk Actions #961

Conversation

Aquilaafuadajo
Copy link
Contributor

@Aquilaafuadajo Aquilaafuadajo commented Mar 27, 2024

Should resolve #4887

Description
Currently, on the data view page keyboard support for posts bulk actions doesn't work.

How to test
Using just the keyboard do the following steps:

  1. click bulk action
  2. check the checkboxes using either spacebar or enter
  3. notice the action buttons are no longer disabled
  4. tab backwards (shift + tab) to select any action you want.

@Angamanga This PR is ready for review 🙏🏽

@Aquilaafuadajo Aquilaafuadajo marked this pull request as ready for review March 27, 2024 12:15
Copy link
Contributor

@Angamanga Angamanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix! Approved!

@Angamanga
Copy link
Contributor

@Angamanga To consider for next release

@Angamanga Angamanga closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Outreachy Task Submission] Keyboard Support For Posts Bulk Actions
2 participants