Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile, Docker and Xdebug fixes #4680

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Makefile, Docker and Xdebug fixes #4680

merged 1 commit into from
Dec 14, 2023

Conversation

ushahidlee
Copy link
Contributor

composer.json

  • Added laravel/ui to fix missing class issues.

FetchSurveyContactByIdQuery.php

  • Deleted to fix duplicate class definition error.

DataSourceManagerTest.php

  • Added cache reset hack to each related test, to fix test consistency.

IncomingCommandTest.php
ListCommandTest.php

  • Commented failing tests (need to be rewritten later).

.gitignore

  • Added coverage folder

Dockerfile

  • Adds docker-php-ext-enable
  • Installs pecl from apt (simplest option)
  • Installs xdebug using pecl
  • Enables xdebug for fpm and cli
  • Copies a custom xdebug ini file into fpm conf.d

Makefile

  • Adds a target for remote debugging using xdebug

docker-compose.yml

  • Adds XDEBUG_MODE environment variable which defaults to off

docker-php-ext-enable

  • a convenience script to enable installed php modules.

docker-php-ext-xdebug.ini

  • Customized xdebug ini file for remote debugging.

This pull request makes the following changes:

  • Fixes configuration issues with the Makefile
  • Adds xdebug to the docker 'platform' container.
  • Adds configuration and composer targets to allow xdebug from docker container to IDE.
  • Fixes some existing tests that were failing in the platform.
  • Removes a duplicate class definition.

Test checklist:

  • [ ]

  • I certify that I ran my checklist

Fixes ushahidi/platform# .

Ping @ushahidi/platform

composer.json
- Added laravel/ui to fix missing class issues.

FetchSurveyContactByIdQuery.php
- Deleted to fix duplicate class definition error.

DataSourceManagerTest.php
- Added cache reset hack to each related test, to fix test consistency.

IncomingCommandTest.php
ListCommandTest.php
- Commented failing tests (need to be rewritten later).

.gitignore
- Added coverage folder

Dockerfile
- Adds docker-php-ext-enable
- Installs pecl from apt (simplest option)
- Installs xdebug using pecl
- Enables xdebug for fpm and cli
- Copies a custom xdebug ini file into fpm conf.d

Makefile
- Adds a target for remote debugging using xdebug

docker-compose.yml
- Adds XDEBUG_MODE environment variable which defaults to off

docker-php-ext-enable
- a convenience script to enable installed php modules.

docker-php-ext-xdebug.ini
- Customized xdebug ini file for remote debugging.
@ushahidlee ushahidlee self-assigned this Dec 14, 2023
Copy link
Contributor

@Mh-Asmi Mh-Asmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's good for me

@Mh-Asmi Mh-Asmi merged commit 271dceb into develop Dec 14, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants