Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update easy_COSMOSAC #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

update easy_COSMOSAC #1

wants to merge 1 commit into from

Conversation

shiangtai
Copy link

output temperature, compound names, and composition

Copy link

@ibell ibell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of little things to resolve, but otherwise looks good!

print(db, method, calc_LNAC(T=300, dbname=db, names=['ETHANOL','METHANOL'], composition = [0.3, 0.7], method=method))
names=['ETHANOL', 'METHANOL']
composition=[0.3, 0.7]
T=300
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be hardcoded

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I guess i did too....

composition=[0.3, 0.7]
T=300
print(db, method,names,T,'K',composition, calc_LNAC(T=T, dbname=db, names = names, composition = composition, method=method))
#print(db, method, calc_LNAC(T=300, dbname=db, names=['ETHANOL','METHANOL'], composition = [0.3, 0.7], method=method))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants