Update seccomp program #536
Closed
+1,039
−337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utam0k
approved these changes
Sep 23, 2024
experiment/seccomp/src/seccomp.rs
Outdated
Comment on lines
206
to
217
| if arc == &Arch::X86 { | ||
| match syscalls::x86_64::Sysno::from_str(name) { | ||
| Ok(syscall) => Some(syscall as u64), | ||
| Err(_) => None, | ||
| } | ||
| } else { | ||
| match syscalls::aarch64::Sysno::from_str(name) { | ||
| Ok(syscall) => Some(syscall as u64), | ||
| Err(_) => None, | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
今後もアーキテクチャが増えることは容易に想像つくので match にしておきますか。
There was a problem hiding this comment.
対応遅くなってすみません、以下で修正しました m( - - )m
| } | ||
| } | ||
|
|
||
| pub fn to_instruction(arch: &Arch, action: u32, rule: &Rule) -> Vec<Instruction> { |
There was a problem hiding this comment.
+1 Fromを提案しておいてなんですが、無理せずこれでも十分使いやすいインタフェースだと思います。ありがとうございます。
| pub is_notify: bool | ||
| } | ||
|
|
||
| impl Rule { |
There was a problem hiding this comment.
もし可能だったら別PRでもいいですし、他の方でもいいんですが unit テスト足したいですね。
There was a problem hiding this comment.
unit テストの書き方がまだわからないので、別PRで対応致しますm(- -)m
|
|
|
以下で cargo clipy で怒られたところを修正しておきました |
sat0ken
force-pushed
the
update-seccomp-program
branch
from
af3c009
to
a2c7dc8
Compare
* added selinux functions Signed-off-by: Hiroyuki Moriya <[email protected]> * not use arc Signed-off-by: Hiroyuki Moriya <[email protected]> * follow reviewer comment Signed-off-by: Hiroyuki Moriya <[email protected]> * divided selinux impl into two files Signed-off-by: Hiroyuki Moriya <[email protected]> * fix Signed-off-by: Hiroyuki Moriya <[email protected]> * fix Signed-off-by: Hiroyuki Moriya <[email protected]> * fix Signed-off-by: Hiroyuki Moriya <[email protected]> * use SELinuxLabel struct Signed-off-by: Hiroyuki Moriya <[email protected]> * use pointer instead of clone Signed-off-by: Hiroyuki Moriya <[email protected]> * not loop Signed-off-by: Hiroyuki Moriya <[email protected]> * add main.rs Signed-off-by: Hiroyuki Moriya <[email protected]> --------- Signed-off-by: Hiroyuki Moriya <[email protected]>
Bumps the patch group with 3 updates: [serde](https://github.com/serde-rs/serde), [libc](https://github.com/rust-lang/libc) and [serde_json](https://github.com/serde-rs/json). Updates `serde` from 1.0.207 to 1.0.208 - [Release notes](https://github.com/serde-rs/serde/releases) - [Commits](serde-rs/serde@v1.0.207...v1.0.208) Updates `libc` from 0.2.155 to 0.2.156 - [Release notes](https://github.com/rust-lang/libc/releases) - [Changelog](https://github.com/rust-lang/libc/blob/0.2.156/CHANGELOG.md) - [Commits](rust-lang/libc@0.2.155...0.2.156) Updates `serde_json` from 1.0.124 to 1.0.125 - [Release notes](https://github.com/serde-rs/json/releases) - [Commits](serde-rs/json@v1.0.124...1.0.125) --- updated-dependencies: - dependency-name: serde dependency-type: direct:production update-type: version-update:semver-patch dependency-group: patch - dependency-name: libc dependency-type: direct:production update-type: version-update:semver-patch dependency-group: patch - dependency-name: serde_json dependency-type: direct:production update-type: version-update:semver-patch dependency-group: patch ... Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: sat0ken <[email protected]>
Signed-off-by: sat0ken <[email protected]>
Signed-off-by: sat0ken <[email protected]>
Signed-off-by: sat0ken <[email protected]>
Signed-off-by: sat0ken <[email protected]>
…ch64 Signed-off-by: sat0ken <[email protected]>
Signed-off-by: sat0ken <[email protected]>
Signed-off-by: sat0ken <[email protected]>
Signed-off-by: sat0ken <[email protected]>
Signed-off-by: sat0ken <[email protected]>
Signed-off-by: sat0ken <[email protected]>
sat0ken
force-pushed
the
update-seccomp-program
branch
from
a2c7dc8
to
a7a842b
Compare
Signed-off-by: sat0ken <[email protected]>
sat0ken
force-pushed
the
update-seccomp-program
branch
from
a7a842b
to
43bcdfa
Compare
|
@sat0ken Unfortunately, there are a lot of conflicts with the main branch. May I ask you to solve it? |
|
あ、ここは youki 向きじゃなかったですね。 Close します。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
以下のissueを進めるため、Seccompのサンプルプログラムを改造しました
containers#2724