Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forgot password backend logic + frontend design #73

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

AbeerDas
Copy link
Collaborator

Notion Ticket Link

Reset Password Page Design Implementation

Implementation Description

This PR implements the design for the Reset Password page as specified in the Notion ticket. The functionality includes sending a reset link to the user's email and providing navigation options based on the user's authentication state.

Steps to Test

  1. Logout: Run the frontend and backend and then ensure you are logged out
  2. Navigate to http://localhost:3000/forgot-password.
    • Expected Result: The page should load successfully.
      • Should be the same as the figma designs (shown below)

image

  1. Enter the email you use to log in and click "Send reset link...".
    • Expected Result: You should be redirected to a confirmation frame, and the confirmation message should display the email you just entered.
      • Should look the same as the figma designs (shown below)

image

Confirmation Message
4. Click "Not your email?".

  • Expected Result: You should be taken back to the previous page.

Previous Page
5. Click "Remember Your Password?".

  • Expected Result: You should be redirected back to the main page.
  1. After logging in, navigate back to http://localhost:3000/forgot-password.

    • Expected Result: You should be redirected to the Home Page, preventing access to the Forgot Password page while logged in.

    Home Page Redirection

Review Focus Areas

  • Code Standards: Since this is my first pull request, I would appreciate feedback on adherence to coding standards. Are there better practices for using variables/hooks?
  • Styling Format: Is the styling format applied in this PR acceptable for future implementations?
  • Backend Routes: Does the backend implementation for additional routes meet our standards and expectations?
  • Try catch block: ForgotPasswordPage line 34 I wrote setIsEmailSent(false) (little redundant), however I am not sure what else to put there so maybe look into that

Checklist

  • My PR title is descriptive and uses imperative tense.
  • My commit messages are clear, descriptive, and written in imperative tense. Commits are atomic, and trivial ones are squashed or fixed into more meaningful commits.
  • I have run the appropriate linter(s).
  • I have requested a review from the Product Lead and relevant developers who have context on this PR or will build upon it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant