Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

un-commented email service related calls #33

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

jerry-cheng5
Copy link
Contributor

Notion ticket link

Ticket Name

Implementation description

  • Not much in terms of code changes
  • Un-commented calls to email service
  • Everyone will need to update their local .env files with the new Mailer secrets

Steps to test

  1. Apply the secrets to your .env file (I'll send it in the slack)
  2. Delete your account from firebase and your local DB
  3. Sign up again with your email.
  4. You should receive an email from [email protected] to verify your email!

What should reviewers focus on?

  • Lmk if you run into any errors

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

Copy link
Contributor

@laks0407 laks0407 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works great!

@jerry-cheng5 jerry-cheng5 added this pull request to the merge queue Oct 1, 2024
Merged via the queue into main with commit 487ef02 Oct 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants