Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: delete classroom button on classroom cards #459

Merged
merged 5 commits into from
Jul 29, 2023

Conversation

d282liu
Copy link
Contributor

@d282liu d282liu commented Jul 12, 2023

Notion ticket link

Delete classroom button

Implementation description

  • created delete class mutation
  • call mutation from front end when clicking delete button in drop down

Steps to test

  1. Try deleting classes

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@d282liu d282liu requested a review from a team July 12, 2023 18:46
@github-actions
Copy link

github-actions bot commented Jul 12, 2023

Visit the preview URL for this PR (updated for commit 9f3f201):

https://jump-math-staging--pr459-david-delete-classro-iqfeibt3.web.app

(expires Sun, 30 Jul 2023 00:43:09 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c42d8d0d853b05885664a2dd73f8245f4333ae51

joyce-shi
joyce-shi previously approved these changes Jul 15, 2023
Copy link
Contributor

@joyce-shi joyce-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice (:

@joyce-shi joyce-shi dismissed their stale review July 15, 2023 17:51

upon double-checking

@d282liu d282liu requested review from joyce-shi and a team July 23, 2023 00:24
Copy link
Collaborator

@carissa-tang carissa-tang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! lgtm

@d282liu d282liu merged commit 01eeac2 into staging Jul 29, 2023
8 checks passed
@d282liu d282liu deleted the david/Delete-classroom-button branch July 29, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants