Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: classroom card spacing #460

Merged
merged 2 commits into from
Jul 16, 2023
Merged

fix: classroom card spacing #460

merged 2 commits into from
Jul 16, 2023

Conversation

joyce-shi
Copy link
Contributor

Notion ticket link

Fix spacing on classroom cards

Implementation description

  • Using Flexbox to adapt the # of columns based on screen size
    i.e

Steps to test

  1. UI renders as expected

@github-actions
Copy link

github-actions bot commented Jul 16, 2023 •
edited
Loading

Visit the preview URL for this PR (updated for commit 05ca103):

https://jump-math-staging--pr460-joyce-fix-classroom-s3q42nho.web.app

(expires Sun, 23 Jul 2023 12:53:03 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c42d8d0d853b05885664a2dd73f8245f4333ae51

@joyce-shi joyce-shi requested a review from a team July 16, 2023 12:49
jfdoming
jfdoming approved these changes Jul 16, 2023
View reviewed changes
Copy link
Contributor

@jfdoming jfdoming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprised this was needed since IIRC this is exactly the case CSS grid is supposed to handle, but if it works it works 👍

@joyce-shi joyce-shi merged commit 39e2e82 into staging Jul 16, 2023
7 checks passed
@joyce-shi joyce-shi deleted the joyce/fix-classroom-card-spacing branch July 16, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfdoming jfdoming jfdoming approved these changes

@carissa-tang carissa-tang Awaiting requested review from carissa-tang

@d282liu d282liu Awaiting requested review from d282liu

Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joyce-shi @jfdoming