-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: choose classroom page (distribute assessment - page 2) #461
Conversation
…-assessment-page-2
Visit the preview URL for this PR (updated for commit 13b3429): https://jump-math-staging--pr461-joyce-distribute-ass-31j17hfi.web.app (expires Sat, 29 Jul 2023 19:32:37 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c42d8d0d853b05885664a2dd73f8245f4333ae51 |
); | ||
}; | ||
|
||
export default EmptyDistributeClassroomsMessage; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not specced by design but took some liberties here.
frontend/src/components/teacher/session-creation/steps/ChooseClass.tsx
Outdated
Show resolved
Hide resolved
</LinkOverlay> | ||
<ClassroomPopover /> | ||
</> | ||
)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, I didn't think the differences warranted a separate component, so just tried to make this one accommodate the minor differences from this view.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lookin good! left a few comments
frontend/src/components/teacher/student-management/classrooms/ClassroomCard.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/common/info/messages/EmptyDistributeClassroomsMessage.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/teacher/session-creation/steps/ChooseClass.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/teacher/session-creation/steps/ChooseClass.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! one small comment, but approving to unblock you
frontend/src/components/pages/teacher/DisplayAssessmentsPage.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/teacher/session-creation/DistributeAsessmentWrapper.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually wait, it looks like the search count is wrong. looks like we're taking the length of the search keyword, not the results
Notion ticket link
Choose Classroom page
Implementation description
There are some design liberties I took here, such as empty states and hover behaviour, but I think we can sync up with design on this when we do a full review.
One key difference - I left the search bar off of this page. We don't implement a search bar for the Classrooms page, so I don't think it makes sense to implement one here. I think if we do want to, we should align to add this search bar to both views, so leaving it off this one for now.