feat: choose classroom page (distribute assessment - page 2) #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-assessment-page-2
joyce-shi
changed the base branch from
staging
to
joyce/fix-classroom-card-spacing
|
Visit the preview URL for this PR (updated for commit 13b3429): https://jump-math-staging--pr461-joyce-distribute-ass-31j17hfi.web.app (expires Sat, 29 Jul 2023 19:32:37 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c42d8d0d853b05885664a2dd73f8245f4333ae51 |
joyce-shi
commented
Jul 16, 2023
| ); | ||
| }; | ||
|
|
||
| export default EmptyDistributeClassroomsMessage; |
There was a problem hiding this comment.
Not specced by design but took some liberties here.
joyce-shi
commented
Jul 16, 2023
frontend/src/components/teacher/session-creation/steps/ChooseClass.tsx
Outdated
Show resolved
Hide resolved
joyce-shi
commented
Jul 16, 2023
| </LinkOverlay> | ||
| <ClassroomPopover /> | ||
| </> | ||
| )} |
There was a problem hiding this comment.
Same here, I didn't think the differences warranted a separate component, so just tried to make this one accommodate the minor differences from this view.
frontend/src/components/teacher/student-management/classrooms/ClassroomCard.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/common/info/messages/EmptyDistributeClassroomsMessage.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/teacher/session-creation/steps/ChooseClass.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/teacher/session-creation/steps/ChooseClass.tsx
Outdated
Show resolved
Hide resolved
carissa-tang
approved these changes
Jul 22, 2023
frontend/src/components/pages/teacher/DisplayAssessmentsPage.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/teacher/session-creation/DistributeAsessmentWrapper.tsx
Show resolved
Hide resolved
carissa-tang
requested changes
Jul 22, 2023
There was a problem hiding this comment.
actually wait, it looks like the search count is wrong. looks like we're taking the length of the search keyword, not the results
carissa-tang
approved these changes
Jul 22, 2023
joyce-shi
added
ready for review
ready to merge
and removed
requested changes
ready for review
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notion ticket link
Choose Classroom page
Implementation description
There are some design liberties I took here, such as empty states and hover behaviour, but I think we can sync up with design on this when we do a full review.
One key difference - I left the search bar off of this page. We don't implement a search bar for the Classrooms page, so I don't think it makes sense to implement one here. I think if we do want to, we should align to add this search bar to both views, so leaving it off this one for now.