Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change teacher dashboard tab design to standard tabs #580

Merged
merged 6 commits into from
Sep 23, 2023

Conversation

jfdoming
Copy link
Contributor

Notion ticket link

Update Teacher Dashboard test sessions to use existing tab design

Implementation description

  • Update tabs on teacher dashboard to use the normal design

Steps to test

  1. View tabs

What should reviewers focus on?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@jfdoming
Copy link
Contributor Author

image

@github-actions
Copy link

github-actions bot commented Sep 13, 2023

Visit the preview URL for this PR (updated for commit 812bbe2):

https://jump-math-staging--pr580-julian-fix-teacher-d-49tliyb3.web.app

(expires Sat, 30 Sep 2023 04:29:18 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c42d8d0d853b05885664a2dd73f8245f4333ae51

Copy link
Collaborator

@carissa-tang carissa-tang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@jfdoming jfdoming merged commit ce25643 into staging Sep 23, 2023
7 checks passed
@jfdoming jfdoming deleted the julian/fix-teacher-dashboard-tab-design branch September 23, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants