Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add times to assessment date pickers #607

Merged
merged 5 commits into from
Nov 20, 2023
Merged

Conversation

jfdoming
Copy link
Contributor

Notion ticket link

Add start / end time in test session

Implementation description

times! Add times to assessment date pickers. Classroom picker to follow.

Steps to test

  1. Create a new assessment (as a teacher) and set a time.
  2. Edit an assessment and view/set the time.

What should reviewers focus on?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@jfdoming jfdoming temporarily deployed to staging October 29, 2023 19:18 — with GitHub Actions Inactive
@jfdoming jfdoming changed the base branch from staging to julian/refactor-common-selects October 29, 2023 19:18
@jfdoming jfdoming temporarily deployed to staging October 29, 2023 19:20 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Oct 29, 2023

Visit the preview URL for this PR (updated for commit 68887bc):

https://jump-math-staging--pr607-julian-add-time-pick-gyys2bbl.web.app

(expires Wed, 22 Nov 2023 04:54:45 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c42d8d0d853b05885664a2dd73f8245f4333ae51

Copy link
Collaborator

@carissa-tang carissa-tang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we update these to show start time (for upcoming) and end time (for active)?

image

frontend/src/components/common/form/DateTimePicker.tsx Outdated Show resolved Hide resolved
frontend/src/components/common/form/TimePicker.tsx Outdated Show resolved Hide resolved
frontend/src/components/common/form/TimePicker.tsx Outdated Show resolved Hide resolved
Base automatically changed from julian/refactor-common-selects to staging November 14, 2023 14:12
@jfdoming
Copy link
Contributor Author

should we update these to show start time (for upcoming) and end time (for active)?

image

I think in the interest of small screens, since this is just the start date, I think it would be fine to truncate to the nearest day? Let me know if you see a justification for including the exact time, but IMHO if a teacher assigns multiple assessments on the same day they'll probably name them like "Counting Test," "Shapes Test," etc., so it won't be hard to differentiate.

Copy link
Collaborator

@carissa-tang carissa-tang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome work !! 🚀

@carissa-tang carissa-tang added ready to merge and removed question Further information is requested ready for review labels Nov 20, 2023
@jfdoming jfdoming merged commit 839df19 into staging Nov 20, 2023
4 checks passed
@jfdoming jfdoming deleted the julian/add-time-picker branch November 20, 2023 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants