Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create michael-town.yaml #24

Merged
merged 6 commits into from
Jun 27, 2024
Merged

Create michael-town.yaml #24

merged 6 commits into from
Jun 27, 2024

Conversation

michaeltown-phd
Copy link
Contributor

No description provided.

@JessicaS11 JessicaS11 added the preview Trigger preview of website via PR label Jun 18, 2024
team/michael-town.yaml Outdated Show resolved Hide resolved
fixed indentation
Copy link

github-actions bot commented Jun 18, 2024

team/michael-town.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@scottyhq scottyhq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Co-authored-by: Scott Henderson <[email protected]>
@ZihengSun
Copy link
Contributor

The issue is that the name cannot have any special characters like brackets. Please remove the brackets and the popup intro will work again.

team/michael-town.yaml Outdated Show resolved Hide resolved
@jomey jomey mentioned this pull request Jun 27, 2024
@JessicaS11
Copy link
Contributor

JessicaS11 commented Jun 27, 2024

The issue is that the name cannot have any special characters like brackets. Please remove the brackets and the popup intro will work again.

@ZihengSun - @jomey fixed this for us in #57!

@michaeltown-phd There's now also a pronouns option! Thanks for suggesting we add that.

team/michael-town.yaml Outdated Show resolved Hide resolved
team/michael-town.yaml Outdated Show resolved Hide resolved
Copy link
Contributor Author

@michaeltown-phd michaeltown-phd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me. Thanks for taking care of it!

@michaeltown-phd
Copy link
Contributor Author

Is there anything more for me to do here? Or can you publish it?

@scottyhq
Copy link
Contributor

the 'read more' bio link still isn't rendering so we'll have to adjust something, but nothing more to do on your part @michaeltown-phd :)

@@ -14,7 +14,8 @@ find . -type f -name '*.yaml' \
sort | xargs -I '{}' cat '{}' > team_people.yaml

# Indent to proper yaml
sed -i 's/^/ /' team_people.yaml
sed -i.bkp -e 's/^/ /' team_people.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@scottyhq scottyhq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just needed to merge with the main branch which has @jomey 's great addition of the pronouns field. Thanks all!

@scottyhq scottyhq merged commit a5d023e into main Jun 27, 2024
1 check passed
@scottyhq scottyhq deleted the michaeltown-phd-patch-1 branch June 27, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Trigger preview of website via PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants