-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create michael-town.yaml #24
Conversation
fixed indentation
🚀 Deployed on https://deploy-preview-24--event-page-2024.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above suggestion to get the multiline bio to render (https://stackoverflow.com/questions/3790454/how-do-i-break-a-string-in-yaml-over-multiple-lines/21699210#21699210)
Co-authored-by: Scott Henderson <[email protected]>
The issue is that the name cannot have any special characters like brackets. Please remove the brackets and the popup intro will work again. |
@ZihengSun - @jomey fixed this for us in #57! @michaeltown-phd There's now also a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good to me. Thanks for taking care of it!
Is there anything more for me to do here? Or can you publish it? |
the 'read more' bio link still isn't rendering so we'll have to adjust something, but nothing more to do on your part @michaeltown-phd :) |
@@ -14,7 +14,8 @@ find . -type f -name '*.yaml' \ | |||
sort | xargs -I '{}' cat '{}' > team_people.yaml | |||
|
|||
# Indent to proper yaml | |||
sed -i 's/^/ /' team_people.yaml | |||
sed -i.bkp -e 's/^/ /' team_people.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just needed to merge with the main branch which has @jomey 's great addition of the pronouns field. Thanks all!
No description provided.