use personal access token instead of GH token #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottyhq
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #159, a PAT (not GH) token is required. Also, we missed some required parameters.
@jomey It looks like the updates are commit based (presumably IDed based on commit timestamps), and the most recent commit in the template repo is used as the branch ID in the PR opened to the templated repo. As a result (1) we didn't see any changes to our open PR with the
is_pr_cleanupbecause that was still the most recent commit in the template repo; (2) even though we addedis_force_deletion: Truea new run doesn't pick up the deleted files (because I'd merged the previous round of updates in).