Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[oneDPL] Create a subsection for is_execution_policy type trait #567

Merged
merged 12 commits into from
Oct 10, 2024

Conversation

akukanov
Copy link
Contributor

This PR describes oneDPL is_execution_policy trait in more detail, and also addresses #558.

Copy link
Contributor

@danhoeflinger danhoeflinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, optional comment about the decay note.

Copy link
Contributor

@danhoeflinger danhoeflinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@rarutyun rarutyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good to me. I left some small comments that do look as improvements to me. But you might disagree

Comment on lines 215 to 216
to the same class template. It is unspecified in which namespace the underlying class template and its specializations
are defined.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
to the same class template. It is unspecified in which namespace the underlying class template and its specializations
are defined.
to the same class template. It is unspecified, which namespace the underlying class template and its specializations
are defined in.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spellcheckers do not complain :), so I will keep this intact.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, this is small suggestion. As far as I understand "preposition + which" is consider to be poorer English. More common use is "bla-bla, which + <proposition at the end>. Again, not proposing to change that but for my curiosity we could summon a native speaker. @danhoeflinger, could you please share your opinion?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I searched for clarification on this, and I have found that "preposition + which" is considered not poorer but more formal English.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that "in which" is more formal (but a bit awkward), and "which ... in" is less formal, and a "dangling preposition" https://www.thefreedictionary.com/Dangling-Prepositions.htm which is a classic English grammar issue.

I was trying to rephrase to avoid the problem, but I think it may make it less clear.

"The location of the underlying class template definition and its specializations is left unspecified."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another option, avoiding the preposition:
"It is unspecified, which namespace contains the underlying class template definition and its specializations."

Copy link
Contributor Author

@akukanov akukanov Oct 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Dan, I like the last suggestion, will apply it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"It is unspecified, which namespace contains the underlying class template definition and its specializations."

I also like that.

... not poorer but more formal English.

Thanks for clarification

Comment on lines 215 to 216
to the same class template. It is unspecified in which namespace the underlying class template and its specializations
are defined.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, this is small suggestion. As far as I understand "preposition + which" is consider to be poorer English. More common use is "bla-bla, which + <proposition at the end>. Again, not proposing to change that but for my curiosity we could summon a native speaker. @danhoeflinger, could you please share your opinion?

struct is_execution_policy { /*see below*/ };

template <class T>
constexpr inline bool is_execution_policy_v = oneapi::dpl::is_execution_policy<T>::value;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
constexpr inline bool is_execution_policy_v = oneapi::dpl::is_execution_policy<T>::value;
inline constexpr bool is_execution_policy_v = oneapi::dpl::is_execution_policy<T>::value;

I prefer that order because this is the way it's defined in C++ standard. I don't want to hold this PR because of that issue but if you decide to change it the way I am suggesting, please ping me and I approve this patch once again.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem, I will do it. No re-approval is needed, thanks.

@akukanov akukanov merged commit 61ebe78 into uxlfoundation:main Oct 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants