Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[oneMKL][LAPACK] Fix ldc size requirements in {or,un}mtr related files #600

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

sknepper
Copy link
Contributor

@sknepper sknepper commented Nov 5, 2024

For ormtr and unmtr, the specification incorrectly specifies that LDC must be >= max(1,n), when in fact it should be >= max(1,m).
This was done for all {or,un}mtr related APIs (buffer, USM, and scratchpad size).
Also changed notation in these files to ld* >= x instead of x <= ld*.
Fixed an issue where the first row of the input parameters table had been bolded (incorrectly considered a header row) and added missing table to unmtr_scratchpad_size.

@ericlars
Copy link
Contributor

ericlars commented Nov 8, 2024

Did you build it? The only change I don't know the effect of is

:header-rows: 0

@sknepper
Copy link
Contributor Author

sknepper commented Nov 8, 2024

Did you build it? The only change I don't know the effect of is

:header-rows: 0

Yes, I built it locally. That change says there are no header rows. With the current code, you can see here: https://oneapi-spec.uxlfoundation.org/specifications/oneapi/v1.3-rev-1/elements/onemkl/source/domains/lapack/ormtr
that the first row of the input parameter table about r is bolded (compare the formatting of "if" in the two lines).
Thanks for the question!

@ericlars
Copy link
Contributor

ericlars commented Nov 8, 2024

Gotcha, thanks

@sknepper sknepper merged commit d151e1e into uxlfoundation:main Nov 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants