mix: reimplement based on std::lerp reference implementation. #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The referenced paper explains the problems with various other implementations of lerp/mix, including ours.
coldav
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
mix: reimplement based on std::lerp reference implementation.
Reason for change
The referenced paper explains the problems with various other implementations of lerp/mix, including ours.
Description of change
An implementation of mix is used that follows std::lerp.
Anything else we should know?
This change will make us fail the SYCL CTS, because of problematic testing in the SYCL CTS. I am opening up an issue against SYCL CTS about that. Hopefully they agree.
Checklist
recent version available through
pip) on all modified code.