Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remaining priority ubuntu PR jobs #571

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Remaining priority ubuntu PR jobs #571

wants to merge 20 commits into from

Conversation

alan-forbes-cp
Copy link
Collaborator

@alan-forbes-cp alan-forbes-cp commented Oct 22, 2024 •
edited
Loading

Overview

Adding the following Gitlab MR jobs to Github:

  • mr-ubuntu-gcc-x86-llvm-latest-x86_64-images-cl3-0-release
  • mr-ubuntu-gcc-aarch64-llvm-previous-cl3-0-fp16
  • mr-ubuntu-gcc-x86_64-riscv-fp16-cl3-0

Reason for change

Jobs have been identified as priority Github jobs.

Description of change

Jobs added to the run_pr_tests.yml file

All jobs tested in-situ.

Anything else we should know

  • compiler input params to build action (plus defaults) have been removed in favour of adding these settings to extra_flags as required.
  • added "save: inputs_update_cache" to jobs as required
  • in setup_build, 'arch' has been refactored into 'runner.arch' (built-in) and 'cross_arch'
  • in setup_build, a new step has been added to define llvm-key version and architecture.

@alan-forbes-cp alan-forbes-cp changed the title DRAFT: First cut of riscv/fp16 job DRAFT: Priority ubuntu PR jobs Oct 22, 2024
@alan-forbes-cp alan-forbes-cp marked this pull request as ready for review October 24, 2024 15:42
@alan-forbes-cp alan-forbes-cp requested a review from a team as a code owner October 24, 2024 15:42
@alan-forbes-cp alan-forbes-cp changed the title DRAFT: Priority ubuntu PR jobs Remaining priority ubuntu PR jobs Oct 24, 2024
@alan-forbes-cp alan-forbes-cp force-pushed the alan/OR-592_priority_ubuntu_pr_jobs branch from b7b7a15 to 6488711 Compare October 24, 2024 15:53
@alan-forbes-cp alan-forbes-cp force-pushed the alan/OR-592_priority_ubuntu_pr_jobs branch from 6488711 to ad96465 Compare November 4, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coldav coldav coldav approved these changes

@hvdijk hvdijk hvdijk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alan-forbes-cp @hvdijk @coldav