Allow spawning multiple prefabs #125
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `StaticObject` used fixed-size Eigen vectors, but `EIGEN_MAKE_ALIGNED_OPERATOR_NEW` had not been added accordingly. - `Quadrotor::getQuaternion()` was declared but not implemented.
While updating objects and vehicles, allow also to change their size.
Added simple demo that allows to spawn and move around objects at runtime. Also, fixed format error in `unity_bridge.cpp`.
|
Ping! |
|
@francofusco LGTM |
jonlee48
added a commit
to rislab/flightmare
that referenced
this pull request
Jun 3, 2024
Added changes from develop to PR uzh-rpg#125
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is closely related to #77 and uzh-rpg/flightmare_unity#8. The goal is to improve and show how to insert and move/scale different static objects in Unity. As mentioned in uzh-rpg/flightmare_unity#8, it might be interesting to allow not only to add but also remove objects at runtime. If you wish such a feature, please do not merge this PR yet 😉
StaticObject- my bad, I forgot it in my previous PR NewStaticObjectAPI #107 😅Quadrotor::getQuaternion()(it was declared in the header, but the implementation in the cpp had likely been deleted by mistake or forgotten)flightrosthat can spawn and move arbitrary objects in the scene. Just a demo to show that the sibling PR Allow spawning multiple prefabs flightmare_unity#8 works!