Fix tls.WithDestination ignoring IP address

[dyhkwong]

ServerName should be filled with server address if tlsSettings.serverName is not specified.

ServerName is used to verify the hostname on the returned certificates unless InsecureSkipVerify is given. It is also included in the client's handshake to support virtual hosting unless it is an IP address.

It is rare to have a certificate with IP addresses as Subject Alternate Name. However, this is indeed a bug, and this can be tested with self-signed certificates. Maybe the original author confused ServerName with SNI.

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.71%. Comparing base (5ca0f36) to head (b16e7f0).
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3177      +/-   ##
==========================================
+ Coverage   38.68%   38.71%   +0.03%     
==========================================
  Files         760      760              
  Lines       43598    43605       +7     
==========================================
+ Hits        16867    16883      +16     
+ Misses      24878    24872       -6     
+ Partials     1853     1850       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[xiaokangwang]

Thanks for your contribution! I think this pull request is ready to be merged in the next release.