Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(CI): ensure CI tasks are run on develop branch #4

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Conversation

0x-r4bbit
Copy link
Contributor

Given that most of the work is currently happening in develop we should run CI tasks there.
Otherwise we'll have too much code additions that aren't reviewed by anyone.

Also, generally, it'd be cool @3esmit if you added your changes via pull requests. This gives other people on the team a chance to take a look and leave feedback.

Checklist

Ensure you completed all of the steps below before submitting your pull request:

  • Added natspec comments?
  • Ran forge snapshot?
  • Ran pnpm lint?
  • Ran forge test?

@0x-r4bbit 0x-r4bbit requested a review from 3esmit December 6, 2023 11:15
@0x-r4bbit 0x-r4bbit merged commit 7419cc3 into main Dec 11, 2023
4 checks passed
@0x-r4bbit 0x-r4bbit deleted the ci-develop branch December 11, 2023 10:02
@0x-r4bbit 0x-r4bbit restored the ci-develop branch December 11, 2023 10:03
@0x-r4bbit 0x-r4bbit deleted the ci-develop branch December 11, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant