-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add initial logging #42
Conversation
6cb5194
to
3da3d4a
Compare
a low-level library like quic should not do logging - it is too far from the application domain and there are many cases where logging in quic would be invasive to the application using it |
if error information is needed, it should not be logged - it should be handed to the callers of the api so they can make logging decisions |
This logging isn't meant for applications using it, but rather to debug issues in the code. It was used to understand why a test wasn't finishing and to discover the deadlock. It is mostly defined as |
It seems other implementations do use logging https://github.com/mozilla/neqo?tab=readme-ov-file#debugging-neqo. |
If we run |
it can also be disabled with |
trace is fine, debug+ is not - ideally all logging in the library would be disabled by default at which point it could do whatever logging it wants, but I don't think that's possible with chronicles - if you can find a way to arrange it in such a way that it's fully opt-in (at compile-time), that's fine too. |
I believe it means that if we run |
c737c92
to
d566772
Compare
This reverts commit 9f265c8.
This PR adds the logs used to find the cause of the deadlock fixed in ca9a029.
Related to #41