Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added apis for planned maintenance mode #115

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jasquat
Copy link
Contributor

@jasquat jasquat commented Apr 19, 2022

In our context, we use probes to indicate environments. These environments are disposable. So when we want to delete and recreate one, we wanted a way to tell vigil that things were not going to be working as usual with the environment during this maintenance period. Specifically, we did not want to receive down and recovery alerts in slack. This pull request adds two apis that allow people to disable and enable notifications for downed probes.

We also added timestamps to logs in src/config/logger.rs. Let us know if this is undesired but it has been really useful for us.

@jasquat jasquat changed the title added apis for planned maintenace mode added apis for planned maintenance mode Apr 19, 2022
@jasquat jasquat force-pushed the add_apis_for_planned_maintenance branch from 3ac9ea6 to d2a6959 Compare April 19, 2022 20:58
@valeriansaliou
Copy link
Owner

Thank you, I'll review this by next week.

@williamdes
Copy link

Hi @valeriansaliou
Can we have this feature ?

@valeriansaliou
Copy link
Owner

Hi @valeriansaliou
Can we have this feature ?

Hey! It's already possible via: https://github.com/valeriansaliou/vigil/blob/master/PROTOCOL.md#2%EF%B8%8F⃣-insert-a-new-announcement

.service(
web::resource("/probe/stop_planned_maintenance/{probe_id}")
.wrap(middleware_auth.clone())
.guard(guard::Post())

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should that not be a Delete like with the reporter flush endpoint? also the resource endpoint should probably be /maintenance/{probe_id}, similar to the reporter endpoint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants