address comments

Signed-off-by: James Xin <[email protected]>
valkey-io · Oct 21, 2024 · a4802d9 · a4802d9
1 parent 5add46b
commit a4802d9
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/java/client/src/main/java/glide/api/commands/servermodules/Json.java b/java/client/src/main/java/glide/api/commands/servermodules/Json.java
@@ -712,7 +712,7 @@ public static CompletableFuture<Long> arrlen(
      * @return The number of elements deleted. 0 if the key does not exist.
      * @example
      *     <pre>{@code
-     * Json.set(client, "doc", , ".", "{\"a\": 1, \"nested\": {\"a\": 2, \"b\": 3}");
+     * Json.set(client, "doc", ".", "{\"a\": 1, \"nested\": {\"a\": 2, \"b\": 3}");
      * Long result = Json.del(client, "doc").get();
      * assertEquals(result, 1L);
      * }</pre>
@@ -729,7 +729,7 @@ public static CompletableFuture<Long> del(@NonNull BaseClient client, @NonNull S
      * @return The number of elements deleted. 0 if the key does not exist.
      * @example
      *     <pre>{@code
-     * Json.set(client, "doc", , ".", "{\"a\": 1, \"nested\": {\"a\": 2, \"b\": 3}");
+     * Json.set(client, "doc", ".", "{\"a\": 1, \"nested\": {\"a\": 2, \"b\": 3}");
      * Long result = Json.del(client, gs("doc")).get();
      * assertEquals(result, 1L);
      * }</pre>
@@ -747,7 +747,7 @@ public static CompletableFuture<Long> del(@NonNull BaseClient client, @NonNull G
      * @return The number of elements deleted. 0 if the key does not exist, or if the JSON path is invalid or does not exist.
      * @example
      *     <pre>{@code
-     * Json.set(client, "doc", , ".", "{\"a\": 1, \"nested\": {\"a\": 2, \"b\": 3}");
+     * Json.set(client, "doc", ".", "{\"a\": 1, \"nested\": {\"a\": 2, \"b\": 3}");
      * Long result = Json.del(client, "doc", "$..a").get();
      * assertEquals(result, 2L);
      * }</pre>
@@ -766,7 +766,7 @@ public static CompletableFuture<Long> del(
      * @return The number of elements deleted. 0 if the key does not exist, or if the JSON path is invalid or does not exist.
      * @example
      *     <pre>{@code
-     * Json.set(client, "doc", , ".", "{\"a\": 1, \"nested\": {\"a\": 2, \"b\": 3}");
+     * Json.set(client, "doc", ".", "{\"a\": 1, \"nested\": {\"a\": 2, \"b\": 3}");
      * Long result = Json.del(client, gs("doc"), gs("$..a")).get();
      * assertEquals(result, 2L);
      * }</pre>
@@ -784,7 +784,7 @@ public static CompletableFuture<Long> del(
      * @return The number of elements deleted. 0 if the key does not exist.
      * @example
      *     <pre>{@code
-     * Json.set(client, "doc", , ".", "{\"a\": 1, \"nested\": {\"a\": 2, \"b\": 3}");
+     * Json.set(client, "doc", ".", "{\"a\": 1, \"nested\": {\"a\": 2, \"b\": 3}");
      * Long result = Json.forget(client, "doc").get();
      * assertEquals(result, 1L);
      * }</pre>
@@ -801,7 +801,7 @@ public static CompletableFuture<Long> forget(@NonNull BaseClient client, @NonNul
      * @return The number of elements deleted. 0 if the key does not exist.
      * @example
      *     <pre>{@code
-     * Json.set(client, "doc", , ".", "{\"a\": 1, \"nested\": {\"a\": 2, \"b\": 3}");
+     * Json.set(client, "doc", ".", "{\"a\": 1, \"nested\": {\"a\": 2, \"b\": 3}");
      * Long result = Json.forget(client, gs("doc")).get();
      * assertEquals(result, 1L);
      * }</pre>
@@ -820,7 +820,7 @@ public static CompletableFuture<Long> forget(
      * @return The number of elements deleted. 0 if the key does not exist, or if the JSON path is invalid or does not exist.
      * @example
      *     <pre>{@code
-     * Json.set(client, "doc", , ".", "{\"a\": 1, \"nested\": {\"a\": 2, \"b\": 3}");
+     * Json.set(client, "doc", ".", "{\"a\": 1, \"nested\": {\"a\": 2, \"b\": 3}");
      * Long result = Json.forget(client, "doc", "$..a").get();
      * assertEquals(result, 2L);
      * }</pre>
@@ -839,7 +839,7 @@ public static CompletableFuture<Long> forget(
      * @return The number of elements deleted. 0 if the key does not exist, or if the JSON path is invalid or does not exist.
      * @example
      *     <pre>{@code
-     * Json.set(client, "doc", , ".", "{\"a\": 1, \"nested\": {\"a\": 2, \"b\": 3}");
+     * Json.set(client, "doc", ".", "{\"a\": 1, \"nested\": {\"a\": 2, \"b\": 3}");
      * Long result = Json.forget(client, gs("doc"), gs("$..a")).get();
      * assertEquals(result, 2L);
      * }</pre>

diff --git a/java/integTest/src/test/java/glide/modules/JsonTests.java b/java/integTest/src/test/java/glide/modules/JsonTests.java
@@ -336,7 +336,7 @@ public void json_del() {
         assertEquals(
                 JsonParser.parseString(expectedGetResult), JsonParser.parseString(actualGetResult));
 
-        assertEquals(1L, Json.del(client, key, "$").get());
+        assertEquals(1L, Json.del(client, gs(key), gs("$")).get());
         assertEquals(0L, Json.del(client, key).get());
         assertNull(Json.get(client, key, new String[] {"$"}).get());
     }
@@ -356,7 +356,7 @@ public void json_forget() {
         assertEquals(
                 JsonParser.parseString(expectedGetResult), JsonParser.parseString(actualGetResult));
 
-        assertEquals(1L, Json.forget(client, key, "$").get());
+        assertEquals(1L, Json.forget(client, gs(key), gs("$")).get());
         assertEquals(0L, Json.forget(client, key).get());
         assertNull(Json.get(client, key, new String[] {"$"}).get());
     }