Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run full CI matrix on PR label "core functionality changes" #1961

Open
avifenesh opened this issue Jul 17, 2024 · 3 comments
Open

Run full CI matrix on PR label "core functionality changes" #1961

avifenesh opened this issue Jul 17, 2024 · 3 comments
Assignees
Labels
CI CI/CD related enhancement New feature or request
Milestone

Comments

@avifenesh
Copy link
Collaborator

We will run a full matrix CI once a day.
But for major changes for the core functionality will add a label "core functionality changes" that will trigger the full matrix CI on the specific PR in order to avoid backlash on other PR merged after the major changes merge, so we don't need to have to fix broken code later on. Major changes are something like changing to bytes for example.
For usual PR's, like commands etc, that usually has no difference between language versions, like commands and almost all PR's, will avoid triggering the whole matrix.

@avifenesh avifenesh added CI CI/CD related enhancement New feature or request labels Jul 17, 2024
@avifenesh avifenesh added this to the Post GA milestone Jul 17, 2024
@avifenesh avifenesh self-assigned this Jul 17, 2024
@Yury-Fridlyand
Copy link
Collaborator

Is it related to #1882?

@avifenesh
Copy link
Collaborator Author

avifenesh commented Jul 18, 2024

@Yury-Fridlyand Yes it is, wasn't aware of you working on it.
If you already taking care of it, you think it'll be possible for you to add Label To the triggers of the full matrix, when the label is CoreChanges (or something similar), and to add permission protection to this trigger (so just contributors can approve and no one can misuse the label).

@avifenesh
Copy link
Collaborator Author

Might need another method

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI/CD related enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

2 participants