CI - Minimal and full CI matrix impl #2051
Open
+512
−255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avifenesh
added
enhancement
avifenesh
added
Core changes
avifenesh
force-pushed
the
CI/TrrigerByLabel
branch
from
82bfbe1
to
e07f1f0
Compare
avifenesh
force-pushed
the
CI/TrrigerByLabel
branch
from
e07f1f0
to
e78b9b8
Compare
avifenesh
force-pushed
the
CI/TrrigerByLabel
branch
from
e78b9b8
to
218b369
Compare
Yury-Fridlyand
approved these changes
Oct 21, 2024
.github/workflows/npm-cd.yml
Outdated
| @@ -11,6 +11,7 @@ on: | |||
| - .github/workflows/install-rust-and-protoc/action.yml | |||
| - .github/workflows/install-shared-dependencies/action.yml | |||
| - .github/workflows/install-valkey/action.yml | |||
| - .github/workflows/create-test-matrices/action.yml | |||
There was a problem hiding this comment.
please fix indentation
| @@ -9725,7 +9725,7 @@ async def cluster_route_custom_command_slot_route( | |||
| route_class = SlotKeyRoute if is_slot_key else SlotIdRoute | |||
| route_second_arg = "foo" if is_slot_key else 4000 | |||
| primary_res = await glide_client.custom_command( | |||
| ["CLUSTER", "NODES"], route_class(SlotType.PRIMARY, route_second_arg) | |||
| ["CLUSTER", "NODES"], route_class(SlotType.PRIMARY, route_second_arg) # type: ignore | |||
There was a problem hiding this comment.
an artifact of merge?
There was a problem hiding this comment.
Fixes for the failing python CI picked from release branch
There was a problem hiding this comment.
Do you want to backport #2453 to main as another PR?
|
Something went wrong with node CI |
@Yury-Fridlyand Probably again differences between old Redis |
avifenesh
force-pushed
the
CI/TrrigerByLabel
branch
from
218b369
to
0ef69b8
Compare
…ed schedule and label runs Signed-off-by: avifenesh <[email protected]>
avifenesh
force-pushed
the
CI/TrrigerByLabel
branch
from
0ef69b8
to
f0eb3ee
Compare
Signed-off-by: avifenesh <[email protected]>
avifenesh
force-pushed
the
CI/TrrigerByLabel
branch
from
f0eb3ee
to
e9886c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes extensive updates to the CI/CD workflow documentation and configuration files. The changes focus on improving the CI/CD pipeline's flexibility, efficiency, and clarity, particularly by enhancing the matrix configurations for testing across different environments and languages.
Documentation Enhancements:
.github/DEVELOPER.md: Added a comprehensive guide on the CI/CD workflow, detailing workflow triggers, test coverage levels, language-specific workflows, shared components, and customization options.Configuration Updates:
.github/json_matrices/build-matrix.json: Updated build matrix to include new fields such asrunandlanguages, and added support for Amazon Linux. [1] [2].github/json_matrices/engine-matrix.json: Added new engine versions and configurations for Valkey and Redis, including therunfield to specify always-run configurations..github/json_matrices/supported-language-versions.json: Defined supported versions for multiple languages, specifying which versions should always be run.Workflow Enhancements:
.github/workflows/create-test-matrices/action.yml: Created a new action for dynamically generating test matrices based on inputs and event types, supporting flexible CI/CD workflows..github/workflows/csharp.yml: Updated workflow to use the new dynamic matrix generation action, added new inputs for manual triggers, and adjusted job configurations for improved testing efficiency. [1] [2]