Python: adds JSON.STRLEN, JSON.STRAPPEND commands #2372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shohamazon
temporarily deployed
to
AWS_ACTIONS
GitHub Actions
Inactive
shohamazon
temporarily deployed
to
AWS_ACTIONS
GitHub Actions
Inactive
shohamazon
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Failure
4 tasks
| For more information about the returned type, see `TJsonResponse`. | ||
|
|
||
| Examples: | ||
| >>> from glide import json as redisJson |
There was a problem hiding this comment.
Suggested change
| >>> from glide import json as redisJson | |
| >>> from glide import json |
remove or rename alias everywhere
There was a problem hiding this comment.
Yeah you're right
acarbonetto
reviewed
Oct 8, 2024
| """ | ||
| Appends the specified `value` to the string stored at the specified `path` within the JSON document stored at `key`. | ||
|
|
||
| See https://redis.io/commands/json.strapped/ for more details. |
There was a problem hiding this comment.
Suggested change
| See https://redis.io/commands/json.strapped/ for more details. | |
| See https://redis.io/commands/json.strappend/ for more details. |
| client (TRedisClient): The Redis client to execute the command. | ||
| key (TEncodable): The key of the JSON document. | ||
| value (TEncodable): The value to append to the string. Must be wrapped with single quotes. For example, to append "foo", pass '"foo"'. | ||
| path (Optional[TEncodable]): The JSONPath to specify. Default is root `$`. |
There was a problem hiding this comment.
Suggested change
| path (Optional[TEncodable]): The JSONPath to specify. Default is root `$`. | |
| path (Optional[TEncodable]): Represents the path within the JSON document where the string value will be appended. Default is root `$`. |
To be consistent. Although, this description is much too verbose. I'd prefer that we go with something concise that mirrors the command description, like:
Path within the JSON document. If not specified, the root (`$`) is used.
There was a problem hiding this comment.
fixed all of them, added Default to None. since the documentation say its $ but its actually . so I better not specify whats exactly it is
acarbonetto
reviewed
Oct 8, 2024
|
|
||
| Examples: | ||
| >>> from glide import json as redisJson | ||
| >>> import json |
There was a problem hiding this comment.
you also have json here, and you use json.dump.
shohamazon
force-pushed
the
python/json.strlen
branch
from
b7e5396
to
ad92730
Compare
shohamazon
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Failure
shohamazon
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Failure
Signed-off-by: Shoham Elias <[email protected]>
shohamazon
force-pushed
the
python/json.strlen
branch
from
ad92730
to
1ae938b
Compare
shohamazon
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Failure
shohamazon
temporarily deployed
to
AWS_ACTIONS
GitHub Actions
Inactive
This was referenced Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaced #1187