Python: adds JSON.ARRPOP command #2407
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shoham Elias <[email protected]>
shohamazon
force-pushed
the
python/json.arrpop
branch
from
b378399
to
a52ebf5
Compare
shohamazon
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Failure
| key: TEncodable, | ||
| options: Optional[JsonArrPopOptions] = None, | ||
| ) -> Optional[TJsonResponse[bytes]]: | ||
| """ |
There was a problem hiding this comment.
Tell how command behaves if no options given and show such examples
| assert await json.set(glide_client, key, "$", json_value) == OK | ||
|
|
||
| assert await json.arrpop( | ||
| glide_client, key, JsonArrPopOptions(path="$.a", index=1) |
There was a problem hiding this comment.
Test without options
| options: Optional[JsonArrPopOptions] = None, | ||
| ) -> Optional[TJsonResponse[bytes]]: | ||
| """ | ||
| Pops the last element from the array located at the specified path within the JSON document stored at `key`. |
| self.path = path | ||
| self.index = index | ||
|
|
||
| def get_options(self) -> List[TEncodable]: |
There was a problem hiding this comment.
rename to toArgs or to_args to align with other option classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.