Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update protoc #2421

Open
wants to merge 2 commits into
base: release-1.1
Choose a base branch
from
Open

Update protoc #2421

wants to merge 2 commits into from

Conversation

Yury-Fridlyand
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand commented Oct 10, 2024 •
edited
Loading

Update protoc to most recent version.

@Yury-Fridlyand
update protoc
0c2d062 
Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner October 10, 2024 18:03
@Yury-Fridlyand
update protoc
b4add58 
Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand Yury-Fridlyand linked an issue Oct 10, 2024 that may be closed by this pull request
Update protobuf to the latest version #2423
Open
2 tasks
@alexey-temnikov
Copy link
Collaborator

Please add issue and description.

avifenesh
avifenesh reviewed Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@avifenesh avifenesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide reasoning (it might be straight forward, but still).
What the version's main differences are (at least to what relevant for us).
Extra will be size differences between the versions.

@Yury-Fridlyand
Copy link
Collaborator Author

Just bumping protoc to most recent versions as possible. You can see full change lists on protobuf's repo: https://github.com/protocolbuffers/protobuf/releases

@Yury-Fridlyand Yury-Fridlyand added the protobuf Protobuf, proto and protoc label Oct 11, 2024
@Yury-Fridlyand Yury-Fridlyand added this to the 1.1 milestone Oct 11, 2024
jamesx-improving
jamesx-improving approved these changes Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@jamesx-improving jamesx-improving left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve on confirmation of protobufjs used by node client doesn't need to be updated.

@Yury-Fridlyand
Copy link
Collaborator Author

Node client has the latest version already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avifenesh avifenesh avifenesh left review comments

@jamesx-improving jamesx-improving jamesx-improving approved these changes

Assignees
No one assigned
Labels
protobuf Protobuf, proto and protoc
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.

Update protobuf to the latest version
4 participants
@Yury-Fridlyand @alexey-temnikov @avifenesh @jamesx-improving