Python: adds JSON.ARRINSERT command #2464
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shoham Elias <[email protected]>
shohamazon
temporarily deployed
to
AWS_ACTIONS
GitHub Actions
Inactive
acarbonetto
reviewed
Oct 16, 2024
| @@ -139,6 +139,57 @@ async def get( | |||
| return cast(bytes, await client.custom_command(args)) | |||
There was a problem hiding this comment.
adding at the end of every pr :)
Yury-Fridlyand
approved these changes
Oct 16, 2024
yipin-chen
approved these changes
Oct 17, 2024
yipin-chen
reviewed
Oct 17, 2024
| ) -> TJsonResponse[int]: | ||
| """ | ||
| Inserts one or more values into the array at the specified `path` within the JSON document stored at `key`, before the given `index`. | ||
|
|
There was a problem hiding this comment.
missing the doc link.
Suggested change
| See https://redis.io/docs/latest/commands/json.arrinsert/ for more details. |
Apparently, there is no json document on valkey.io.
There was a problem hiding this comment.
we decided to remove it for now, I'll see what we will do on feature freeze since its not a big deal for now
thanks! |
|
ci is red - rebase? |
| For JSONPath (`path` starts with '$'): | ||
| Returns a list of integer replies for every possible path, indicating the new length of the array, | ||
| or None for JSON values matching the path that are not an array. | ||
| If `path` doe not exist, an empty array will be returned. |
There was a problem hiding this comment.
Suggested change
| If `path` doe not exist, an empty array will be returned. | |
| If `path` does not exist, an empty array will be returned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
This Pull Request is linked to issue (URL): #645
Checklist
Before submitting the PR make sure the following are checked: