Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: Add FT.SEARCH command #2470

Open
wants to merge 21 commits into
base: release-1.2
Choose a base branch
from
Open

Python: Add FT.SEARCH command #2470

wants to merge 21 commits into from
+346 −1

Conversation

prateek-kumar-improving
Copy link
Collaborator

@prateek-kumar-improving prateek-kumar-improving commented Oct 17, 2024 •
edited
Loading

Issue link

This Pull Request is linked to issue (URL): #2429

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Commits will be squashed upon merging.

@prateek-kumar-improving
Python: Add FT.SEARCH command
b571a7f 
Signed-off-by: Prateek Kumar <[email protected]>
@prateek-kumar-improving prateek-kumar-improving requested a review from a team as a code owner October 17, 2024 01:39
@prateek-kumar-improving prateek-kumar-improving mentioned this pull request Oct 17, 2024
Open
15 tasks
@prateek-kumar-improving prateek-kumar-improving changed the title Python: Add FT.SEARCH command Python: Add FT.SEARCH command Oct 17, 2024
acarbonetto
acarbonetto reviewed Oct 17, 2024
View reviewed changes
python/python/glide/async_commands/server_modules/ft.py Outdated Show resolved Hide resolved
python/python/glide/async_commands/server_modules/ft.py Outdated Show resolved Hide resolved
python/python/tests/tests_server_modules/search/test_ft_search.py Outdated Show resolved Hide resolved
python/python/tests/tests_server_modules/search/test_ft_search.py Outdated Show resolved Hide resolved
python/python/tests/tests_server_modules/search/test_ft_search.py Outdated Show resolved Hide resolved
python/python/tests/tests_server_modules/search/test_ft_search.py Outdated Show resolved Hide resolved
python/python/tests/tests_server_modules/search/test_ft_search.py Outdated Show resolved Hide resolved
python/python/tests/tests_server_modules/search/test_ft_search.py Outdated Show resolved Hide resolved
@prateek-kumar-improving
Review comments fixed
67680e9 
Signed-off-by: Prateek Kumar <[email protected]>
@Yury-Fridlyand
Copy link
Collaborator

Add changelog please

@prateek-kumar-improving
CHANGELOG.md updated
327faea 
Signed-off-by: Prateek Kumar <[email protected]>
@prateek-kumar-improving
Python FT.SEARCH fix test
1869075 
Signed-off-by: Prateek Kumar <[email protected]>
@prateek-kumar-improving
Copy link
Collaborator Author

Add changelog please

CHANGELOG.md updated.

@prateek-kumar-improving
Python FT.SEARCH utils updated
c666d07 
Signed-off-by: Prateek Kumar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acarbonetto acarbonetto acarbonetto approved these changes

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

@shohamazon shohamazon Awaiting requested review from shohamazon

Assignees
No one assigned
Labels
python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prateek-kumar-improving @Yury-Fridlyand @acarbonetto