Go: Implementing Copy command #2480
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MikeMwita <[email protected]>
| @@ -30,4 +30,30 @@ type GenericBaseCommands interface { | |||
| // | |||
| // [valkey.io]: https://valkey.io/commands/del/ | |||
| Del(keys []string) (Result[int64], error) | |||
|
|
|||
| // Copy copies the value stored at the source key to the destination key. | |||
There was a problem hiding this comment.
Suggested change
| // Copy copies the value stored at the source key to the destination key. | |
| // Copies the value stored at the source key to the destination key. |
Comment on lines
+38
to
+39
| // Note: | ||
| // - When in cluster mode, the command may route to multiple nodes depending on the location of the source and destination keys. |
There was a problem hiding this comment.
when in cluster, both keys should be managed by the same node.
Please use another notice.
| // Parameters: | ||
| // sourceKey - The key from which to copy the value. | ||
| // destinationKey - The key to copy the value to. | ||
| // destinationDB - An optional integer representing the database index for the destination key. If nil, the current database is used. |
There was a problem hiding this comment.
How we do in docs - nil or nil?
Suggested change
| // destinationDB - An optional integer representing the database index for the destination key. If nil, the current database is used. | |
| // destinationDB - An optional integer representing the database index for the destination key. If `nil`, the current database is used. |
| // replace - A boolean flag indicating whether to replace the destination key if it exists. | ||
| // | ||
| // Return value: | ||
| // Returns 1 if the copy was successful, or 0 if the destination key already exists without the `REPLACE` option. |
There was a problem hiding this comment.
Returns true/false
Please refer to (or even copy) docs from other clients.
Comment on lines
+1987
to
+1988
| key1 := "dolly_" + uuid.New().String() | ||
| key2 := "clone_" + uuid.New().String() |
There was a problem hiding this comment.
This will fail on a cluster
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.